r89721 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89720‎ | r89721 | r89722 >
Date:06:18, 8 June 2011
Author:nad
Status:deferred
Tags:
Comment:
test key existence
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -62,7 +62,7 @@
6363 $records = array();
6464 $content = $editPage->getContent();
6565 foreach( self::examineBraces( $content ) as $brace ) {
66 - if( $brace['DEPTH'] == 2 ) {
 66+ if( array_key_exists( 'DEPTH', $brace ) && $brace['DEPTH'] == 2 ) {
6767 $name = $brace['NAME'];
6868 $form = Title::newFromText( $name, NS_FORM );
6969 if( is_object( $form ) && $form->exists() ) {
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -10,7 +10,7 @@
1111 * @author Siebrand Mazeland
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
14 -define( 'RECORDADMIN_VERSION', '1.2.1, 2011-03-27' );
 14+define( 'RECORDADMIN_VERSION', '1.2.2, 2011-06-08' );
1515
1616 $dir = dirname( __FILE__ ) . '/';
1717 $wgExtensionMessagesFiles['RecordAdmin'] = $dir . 'RecordAdmin.i18n.php';

Status & tagging log