r89715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89714‎ | r89715 | r89716 >
Date:03:01, 8 June 2011
Author:nagelp
Status:ok
Tags:
Comment:
Changed $ngFromAddress init. Using $wgPasswordSenderName and $wgPasswordSender as default for $ngFromAddress
Modified paths:
  • /trunk/extensions/Notificator/Notificator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Notificator/Notificator.php
@@ -26,8 +26,8 @@
2727
2828 $wgExtensionMessagesFiles['Notificator'] = dirname( __FILE__ ) . '/Notificator.i18n.php';
2929
30 -global $wgPasswordSender, $ngFromAddress;
31 -if(! $ngFromAddress) $ngFromAddress = $wgPasswordSender;
 30+// Setting default here, to avoid register_globals vulnerabilites
 31+$ngFromAddress = $wgPasswordSenderName . '<' . $wgPasswordSender . '>';
3232
3333 function notificator_AddDatabaseTable() {
3434 global $wgExtNewTables;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89637Initial commit of new extension Notificatornagelp09:20, 7 June 2011

Status & tagging log