r89674 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89673‎ | r89674 | r89675 >
Date:18:50, 7 June 2011
Author:demon
Status:ok
Tags:
Comment:
Followup r87347, bug 22227, use makeTitleSafe.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListfiles.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListfiles.php
@@ -196,7 +196,8 @@
197197 static $imgfile = null;
198198 if ( $imgfile === null ) $imgfile = wfMsg( 'imgfile' );
199199
200 - $filePage = Title::makeTitle( NS_FILE, $value );
 200+ // Weird files can maybe exist? Bug
 201+ $filePage = Title::makeTitleSafe( NS_FILE, $value );
201202 if( $filePage ) {
202203 $link = $this->getSkin()->linkKnown( $filePage, htmlspecialchars( $filePage->getText() ) );
203204 $download = Xml::element( 'a',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87347(bug 22227) Special:Listfiles no longer throws an error on bogus file entriesdemon19:49, 3 May 2011

Status & tagging log