r89642 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89641‎ | r89642 | r89643 >
Date:11:34, 7 June 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 29297) 'Strike selected sign-offs' shouldn't appear if there are no sign-offs
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -764,7 +764,9 @@
765765 */
766766 protected function signoffButtons( $signOffs ) {
767767 $userSignOffs = $this->getUserSignoffs( $signOffs );
768 - $strikeButton = Xml::submitButton( wfMsg( 'code-signoff-strike' ), array( 'name' => 'wpStrikeSignoffs' ) );
 768+ $strikeButton = count( $userSignOffs )
 769+ ? Xml::submitButton( wfMsg( 'code-signoff-strike' ), array( 'name' => 'wpStrikeSignoffs' ) )
 770+ : '';
769771 $signoffText = wfMsgHtml( 'code-signoff-signoff' );
770772 $signoffButton = Xml::submitButton( wfMsg( 'code-signoff-submit' ), array( 'name' => 'wpSignoff' ) );
771773 $checks = '';

Status & tagging log