r89607 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89606‎ | r89607 | r89608 >
Date:21:00, 6 June 2011
Author:wikinaut
Status:deferred
Tags:
Comment:
follow-up r88400: localized dashboard messages which are not names of variables
Modified paths:
  • /trunk/extensions/OpenID/OpenID.i18n.php (modified) (history)
  • /trunk/extensions/OpenID/OpenID.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDDashboard.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.932-beta' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.933-beta' );
3232
3333 $path = dirname( __FILE__ );
3434 set_include_path( implode( PATH_SEPARATOR, array( $path ) ) . PATH_SEPARATOR . get_include_path() );
Index: trunk/extensions/OpenID/SpecialOpenIDDashboard.body.php
@@ -4,7 +4,6 @@
55 *
66 * @ingroup SpecialPage
77 * @ingroup Extensions
8 - * @version 0.1
98 * @author Thomas Gries
109 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1110 * @link http://www.mediawiki.org/wiki/Extension:OpenID Documentation
@@ -83,7 +82,9 @@
8483 Html::openElement( 'table', array( 'style' => 'width:50%;', 'class' => 'mw-openiddashboard-table wikitable' ) )
8584 );
8685
87 - $out = $this->show( 'MEDIAWIKI_OPENID_VERSION', MEDIAWIKI_OPENID_VERSION );
 86+ # Here we show some basic version infos. Retrieval of SVN revision number of OpenID appears to be too difficult
 87+ $out = $this->show( 'OpenID ' . wfMsg( 'version-software-version' ), MEDIAWIKI_OPENID_VERSION );
 88+ $out .= $this->show( 'MediaWiki ' . wfMsg( 'version-software-version' ), SpecialVersion::getVersion() );
8889 $out .= $this->show( '$wgOpenIDOnly', $wgOpenIDOnly );
8990 $out .= $this->show( '$wgOpenIDClientOnly', $wgOpenIDClientOnly );
9091 $out .= $this->show( '$wgOpenIDAllowServingOpenIDUserAccounts', $wgOpenIDAllowServingOpenIDUserAccounts );
@@ -95,12 +96,11 @@
9697 $out .= $this->show( '$wgOpenIDProposeUsernameFromSREG', $wgOpenIDProposeUsernameFromSREG );
9798 $out .= $this->show( '$wgOpenIDShowUrlOnUserPage', $wgOpenIDShowUrlOnUserPage );
9899 $out .= $this->show( '$wgOpenIDShowProviderIcons', $wgOpenIDShowProviderIcons );
 100+ $out .= $this->show( wfMsgExt( 'statistics-users', array( 'parseinline' ) ), $totalUsers );
 101+ $out .= $this->show( wfMsg( 'openid-dashboard-number-openid-users' ), $OpenIDdistinctUsers );
 102+ $out .= $this->show( wfMsg( 'openid-dashboard-number-openids-in-database' ), $OpenIDUsers );
 103+ $out .= $this->show( wfMsg( 'openid-dashboard-number-users-without-openid' ), $totalUsers - $OpenIDdistinctUsers );
99104
100 - $out .= $this->show( 'Number of users (total)', $totalUsers );
101 - $out .= $this->show( 'Number of users with OpenID', $OpenIDdistinctUsers );
102 - $out .= $this->show( 'Number of OpenIDs (total)', $OpenIDUsers );
103 - $out .= $this->show( 'Number of users without OpenID', $totalUsers - $OpenIDdistinctUsers );
104 -
105105 $wgOut->addHTML( $out . Html::closeElement( 'table' ) . "\n" );
106106
107107 }
Index: trunk/extensions/OpenID/OpenID.i18n.php
@@ -138,6 +138,9 @@
139139 'openid-dashboard-title' => 'OpenID dashboard',
140140 'openid-dashboard-title-admin' => 'OpenID dashboard (administrator)',
141141 'openid-dashboard-introduction' => 'The current OpenID extension settings ([$1 help])',
 142+ 'openid-dashboard-number-openid-users' => 'Number of users with OpenID',
 143+ 'openid-dashboard-number-openids-in-database' => 'Number of OpenIDs (total)',
 144+ 'openid-dashboard-number-users-without-openid' => 'Number of users without OpenID',
142145 );
143146
144147 /** Message documentation (Message documentation)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88400introduced an OpenID special pages group; new restricted special page OpenID ...wikinaut02:48, 19 May 2011

Status & tagging log