r89595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89594‎ | r89595 | r89596 >
Date:19:26, 6 June 2011
Author:reedy
Status:ok
Tags:
Comment:
Revert r89537 till we decide a sane way to have it on/off as API bools suck
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiLogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -99,8 +99,6 @@
100100 * (bug 28897) rvparse doesn’t seem to work with rvsection
101101 * (bug 25734) API: possible issue with revids validation
102102 * (bug 28002) Internal error in ApiFormatRaw::getMimeType
103 -* (bug 26597) Allow toggling of persistent cookies ("remember me") in API
104 - action=login
105103 * (bug 29237) add interwiki target url attribute to api/query/interwiki
106104 * (bug 28392) mark action=undelete&timestamps as type "timestamp"
107105 * (bug 21346) Make deleted images searchable by hash (disabled in Miser Mode)
Index: trunk/phase3/includes/api/ApiLogin.php
@@ -60,12 +60,9 @@
6161 'wpPassword' => $params['password'],
6262 'wpDomain' => $params['domain'],
6363 'wpLoginToken' => $params['token'],
 64+ 'wpRemember' => ''
6465 ) );
6566
66 - if ( $params['rememberme'] ) {
67 - $req['wpRemember'] = '';
68 - }
69 -
7067 // Init session if necessary
7168 if ( session_id() == '' ) {
7269 wfSetupSession();
@@ -171,10 +168,6 @@
172169 'password' => null,
173170 'domain' => null,
174171 'token' => null,
175 - 'rememberme' => array(
176 - ApiBase::PARAM_TYPE => 'boolean',
177 - ApiBase::PARAM_DFLT => true,
178 - ),
179172 );
180173 }
181174
@@ -184,7 +177,6 @@
185178 'password' => 'Password',
186179 'domain' => 'Domain (optional)',
187180 'token' => 'Login token obtained in first request',
188 - 'rememberme' => 'Make the cookies persistant'
189181 );
190182 }
191183

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89537* (bug 26597) Allow toggling of persistent cookies ("remember me") in API...reedy21:50, 5 June 2011

Status & tagging log