r89572 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89571‎ | r89572 | r89573 >
Date:15:34, 6 June 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r89564

showsizediff is disabled in miser mode, make the api check and die as appropriate
Modified paths:
  • /trunk/phase3/includes/api/ApiFeedContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiFeedContributions.php
@@ -54,6 +54,11 @@
5555 $this->dieUsage( 'Invalid subscription feed type', 'feed-invalid' );
5656 }
5757
 58+ global $wgMiserMode;
 59+ if ( $params['showsizediff'] && $wgMiserMode ) {
 60+ $this->dieUsage( 'Size difference is disabled in Miser Mode', 'sizediffdisabled' );
 61+ }
 62+
5863 $msg = wfMsgForContent( 'Contributions' );
5964 $feedTitle = $wgSitename . ' - ' . $msg . ' [' . $wgLanguageCode . ']';
6065 $feedUrl = SpecialPage::getTitleFor( 'Contributions', $params['user'] )->getFullURL();
@@ -174,7 +179,7 @@
175180 'tagfilter' => 'Filter contributions that have these tags',
176181 'deletedonly' => 'Show only deleted contributions',
177182 'toponly' => 'Only show edits that are latest revisions',
178 - 'showsizediff' => '',
 183+ 'showsizediff' => 'Show the size difference between revisions. Disabled in Miser Mode',
179184 );
180185 }
181186
@@ -186,6 +191,7 @@
187192 return array_merge( parent::getPossibleErrors(), array(
188193 array( 'code' => 'feed-unavailable', 'info' => 'Syndication feeds are not available' ),
189194 array( 'code' => 'feed-invalid', 'info' => 'Invalid subscription feed type' ),
 195+ array( 'code' => 'sizediffdisabled', 'info' => 'Size difference is disabled in Miser Mode' ),
190196 ) );
191197 }
192198

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89564* (bug 26763) Make RSS/Atom of user contributions more visible...reedy14:50, 6 June 2011

Status & tagging log