r89466 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89465‎ | r89466 | r89467 >
Date:14:33, 4 June 2011
Author:huji
Status:ok
Tags:
Comment:
Follow up to r89419:
Per Brion's comment on Code Review, a generically named ltr class is created and used to reduce the number of rules
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -709,22 +709,10 @@
710710 background-image: url(images/sort_down.gif);
711711 }
712712
713 -/* Special:Version */
714 -#sv-software td {
715 - /* version numbers are always ltr (and otherwise an RLE can be inserted) */
 713+/* LTR content in RTL layout */
 714+.ltr {
716715 /* @noflip */
717716 direction: ltr;
718 -}
719 -
720 -/* LTR content in RTL layout, e.g. SQL queries inside DB error messages */
721 -div.ltr {
722 - /* @noflip */
723 - direction: ltr;
724 -}
725 -
726 -span.ltr {
727 - /* @noflip */
728 - direction: ltr;
729717 unicode-bidi: embed;
730718 }
731719
Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -146,7 +146,7 @@
147147 foreach( $software as $name => $version ) {
148148 $out .= "<tr>
149149 <td>" . $name . "</td>
150 - <td>" . $version . "</td>
 150+ <td class=\"ltr\">" . $version . "</td>
151151 </tr>\n";
152152 }
153153

Follow-up revisions

RevisionCommit summaryAuthorDate
r106569Remove ltr class (see r89466), it should not be used at all, because 1) the n...robin16:25, 18 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89419(bug 29263) Add LTR class to the shared CSS to be used for left-to-right text...huji16:15, 3 June 2011
r89420Extension to r89419, removing a bugous CSS codehuji16:17, 3 June 2011
r89421Extension to r89419, I was too excited fixing the bughuji16:20, 3 June 2011

Status & tagging log