r89419 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89418‎ | r89419 | r89420 >
Date:16:15, 3 June 2011
Author:huji
Status:ok (Comments)
Tags:
Comment:
(bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL environements
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
——@@ -715,3 +715,16 @@
716716 /* @noflip */
717717 direction: ltr;
718718 }
 719+
 720+/* LTR content in RTL layout, e.g. SQL queries inside DB error messages */
 721+div.ltr {
 722+ /* @noflip */
 723+ direction: ltr;
 724+}
 725+
 726+div.ltr {
 727+ /* @noflip */
 728+ direction: ltr;
 729+ unicode-bidi: embed;RE
 730+}
 731+
Index: trunk/phase3/RELEASE-NOTES-1.18
——@@ -251,6 +251,9 @@
252252 * (bug 22227) Special:Listfiles no longer throws an error on bogus file entries
253253 * (bug 19408) user_properties.up_property: 32 bytes is not enough.
254254 * (bug 25262) Fix for minification of hardcoded data: URIs in CSS
 255+* (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text
 256+ such as SQL queries shown in dberrortext and similar messages in RTL
 257+ environments
255258
256259 === API changes in 1.18 ===
257260 * (bug 26339) Throw warning when truncating an overlarge API result.

Follow-up revisions

RevisionCommit summaryAuthorDate
r89420Extension to r89419, removing a bugous CSS codehuji16:17, 3 June 2011
r89421Extension to r89419, I was too excited fixing the bughuji16:20, 3 June 2011
r89466Follow up to r89419:...huji14:33, 4 June 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:17, 3 June 2011
RE? Why is it restricted to divs? Are you sure the div.ltr part is not flipped?
#Comment by Nikerabbit (talk | contribs)   16:17, 3 June 2011

I mean ";RE". Why are the two blocks not equivalent?

#Comment by Huji (talk | contribs)   16:20, 3 June 2011

Because only DIVs and SPANs are going to be used in the MediaWiki messages to contain LTR content. This will take effect once the new translations are submitted from translatewiki (still working on it).

Also please note that this revision was debugged in r89420 and r89421.

#Comment by Brion VIBBER (talk | contribs)   22:08, 3 June 2011

This comes immediately after another super-specific rule that it doesn't allow replacing: 

/* Special:Version */
#sv-software td {
	/* version numbers are always ltr (and otherwise an RLE can be inserted) */
	/* @noflip */
	direction: ltr;
}

If it makes sense to have a generically-named 'ltr' class at all, it should probably not be randomly limited to divs and spans.

#Comment by Huji (talk | contribs)   14:34, 4 June 2011

I made ltr a generic reusable class style with r89466.

Status & tagging log