r89402 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89401‎ | r89402 | r89403 >
Date:09:56, 3 June 2011
Author:catrope
Status:ok
Tags:
Comment:
(bug 29104) Fix r86622: make splitlines default to false, makes much more sense
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.textSelection.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.textSelection.js
@@ -414,7 +414,7 @@
415415 'ownline': false, // Put the inserted text on a line of its own
416416 'replace': false, // If there is a selection, replace it with peri instead of leaving it alone
417417 'selectPeri': true, // Select the peri text if it was inserted (but not if there was a selection and replace==false)
418 - 'splitlines': true // If multiple lines are selected, encapsulate each line individually
 418+ 'splitlines': false // If multiple lines are selected, encapsulate each line individually
419419 }, options );
420420 break;
421421 case 'getCaretPosition':

Follow-up revisions

RevisionCommit summaryAuthorDate
r89403(bug 29105) Splitlines completely messes up selection of inserted text. This ...catrope10:08, 3 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86622(bug 22209, bug 22574) Make indent, bullet list and numbered list buttons in ...catrope13:42, 21 April 2011

Status & tagging log