r89378 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89377‎ | r89378 | r89379 >
Date:02:10, 3 June 2011
Author:demon
Status:deferred
Tags:
Comment:
* Actually begin() in begin()
* Don't raise silly PEAR error, just throw the exception
Modified paths:
  • /trunk/extensions/OpenID/DatabaseConnection.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/DatabaseConnection.php
@@ -1,7 +1,6 @@
22 <?php
33
44 require_once( 'Auth/OpenID/DatabaseConnection.php' );
5 -require_once( 'PEAR.php' );
65
76 class MediaWikiOpenIDDatabaseConnection extends Auth_OpenID_DatabaseConnection {
87
@@ -20,16 +19,11 @@
2120 }
2221
2322 function query( $sql, $params = array() ) {
24 - try {
25 - $res = $this->db->safeQuery( $sql, $params );
26 - } catch( DBQueryError $e ) {
27 - $ret = PEAR::raiseError( $e->getMessage(), 1, PEAR_ERROR_RETURN );
28 - }
29 - return $res;
 23+ return $this->db->safeQuery( $sql, $params );
3024 }
3125
3226 function begin() {
33 - $this->db->commit();
 27+ $this->db->begin();
3428 }
3529
3630 function commit() {

Status & tagging log