r89345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89344‎ | r89345 | r89346 >
Date:15:42, 2 June 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix regression in r84638, causing ArticleDeleteComplete to be called twice on file deletions. doDeleteArticle() already calls it, there's no need for FileDeleteForm::doDelete() to call it again
Modified paths:
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileDeleteForm.php
——@@ -131,7 +131,6 @@
132132 $status = $file->delete( $reason, $suppress );
133133 if( $status->ok ) {
134134 $dbw->commit();
135 - wfRunHooks( 'ArticleDeleteComplete', array( &$article, &$wgUser, $reason, $id ) );
136135 } else {
137136 $dbw->rollback();
138137 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r92330REL1_18 MFT r88750, r88870, r88871, r89003, r89005, r89114, r89115, r89129, r...reedy22:56, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84638Moving deletion hooks into doArticleDelete so that other code can sanely dele...laner21:54, 23 March 2011

Status & tagging log