r89299 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89298‎ | r89299 | r89300 >
Date:22:27, 1 June 2011
Author:brion
Status:ok
Tags:
Comment:
Add more super-cookie test cases to HttpTest; things like org & .org aren't being handled correctly either. Not super high prio but... should probably mark these tests broken if can't be fixed easily yet.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/HttpTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/HttpTest.php
——@@ -332,6 +332,10 @@
333333
334334 function cookieDomains() {
335335 return array(
 336+ array( false, "org"),
 337+ array( false, ".org"),
 338+ array( true, "wikipedia.org"),
 339+ array( true, ".wikipedia.org"),
336340 array( false, "co.uk" ),
337341 array( false, ".co.uk" ),
338342 array( false, "gov.uk" ),

Status & tagging log