r89292 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89291‎ | r89292 | r89293 >
Date:21:25, 1 June 2011
Author:brion
Status:ok
Tags:
Comment:
Tweak HttpTest following r89278:
* remove FTP test case URL (shouldn't actually work, and as a directory listing, not super stable)
* remove old test case URLs that are now 30x redirects (example.com and a toolserver link), which broke the comparison tests
* added in http://en.wikipedia.org/robots.txt so we've got a nice basic fetch on one of our servers too

Now this test class is down to 3 failures, in URL & domain validation stuff
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/HttpTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/HttpTest.php
@@ -17,11 +17,9 @@
1818 static $has_proxy = false;
1919 static $proxy = "http://hulk:8080/";
2020 var $test_geturl = array(
21 - "ftp://ftp.kernel.org/",
22 - "http://www.example.com/",
 21+ "http://en.wikipedia.org/robots.txt",
2322 "https://secure.wikimedia.org/",
2423 "http://pecl.php.net/feeds/pkg_apc.rss",
25 - "http://toolserver.org/~jan/poll/dev/main.php?page=wiki_output&id=3",
2624 "http://meta.wikimedia.org/w/index.php?title=Interwiki_map&action=raw",
2725 "http://www.mediawiki.org/w/api.php?action=query&list=categorymembers&cmtitle=Category:MediaWiki_hooks&format=php",
2826 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89278Fix Bug #29231: PhpHttpRequest doesn't support HTTPS...mah18:57, 1 June 2011

Status & tagging log