r89251 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89250‎ | r89251 | r89252 >
Date:08:41, 1 June 2011
Author:freakolowsky
Status:deferred
Tags:
Comment:
* updated listTables function to also take in account possible user-dbname difference
* using different database will still probabbly break phpunit tests, but it's a step
Modified paths:
  • /trunk/phase3/includes/db/DatabaseOracle.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseOracle.php
——@@ -824,7 +824,8 @@
825825 $listWhere = ' AND table_name LIKE \''.strtoupper($prefix).'%\'';
826826 }
827827
828 - $result = $this->doQuery( "SELECT table_name FROM user_tables WHERE table_name NOT LIKE '%!_IDX$_' ESCAPE '!' $listWhere" );
 828+ $owner = strtoupper( $this->mDBname );
 829+ $result = $this->doQuery( "SELECT table_name FROM all_tables WHERE owner='$owner' AND table_name NOT LIKE '%!_IDX$_' ESCAPE '!' $listWhere" );
829830
830831 // dirty code ... i know
831832 $endArray = array();

Status & tagging log