r89247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89246‎ | r89247 | r89248 >
Date:01:24, 1 June 2011
Author:brion
Status:ok
Tags:
Comment:
Follow-up to r89243 to fix the async qunit test

Per CR & IRC discussion; added the missing stop() & start() calls, and using the timeout parameter for stop() so we can actually detect the regression (original bug caused neither the success nor failure callbacks to fire, so the test runner would just stop)
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
@@ -176,8 +176,13 @@
177177 test( 'mw.loader.bug29107' , function() {
178178 expect( 1 );
179179
 180+ // Async! Include a timeout, as failure on this bug lead to neither the
 181+ // success nor failure callbacks getting called.
 182+ stop(1500);
 183+
180184 mw.loader.implement( 'bug29107.messages-only', [], {}, {'bug29107': 'loaded'} );
181185 mw.loader.using( 'bug29107.messages-only', function() {
 186+ start();
182187 ok( mw.messages.exists( 'bug29107' ), 'Bug 29107: messages-only module should load ok' );
183188 }, function(){
184189 start();

Follow-up revisions

RevisionCommit summaryAuthorDate
r90076Increasing time-out (testswarm reports false positives from swarmiers with a ...krinkle20:02, 14 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89243Follow-up to r88706: add qunit regression test case for bug 29107....brion00:13, 1 June 2011

Status & tagging log