r89215 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89214‎ | r89215 | r89216 >
Date:13:07, 31 May 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
remove property parameter from compatibility function for creating dataitems fmo dbkeys (was only needed for old records)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/SMW_CompatibilityHelpers.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SqlStubSemanticData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SqlStubSemanticData.php
@@ -86,7 +86,7 @@
8787
8888 foreach ( $this->mStubPropVals[$property->getKey()] as $dbkeys ) {
8989 try {
90 - $di = SMWCompatibilityHelpers::dataItemFromDBKeys( $property->findPropertyTypeID(), $dbkeys, $property );
 90+ $di = SMWCompatibilityHelpers::dataItemFromDBKeys( $property->findPropertyTypeID(), $dbkeys );
9191 if ( $this->mNoDuplicates ) {
9292 $this->mPropVals[$property->getKey()][$di->getHash()] = $di;
9393 } else {
Index: trunk/extensions/SemanticMediaWiki/includes/SMW_CompatibilityHelpers.php
@@ -29,11 +29,10 @@
3030 *
3131 * @param $typeid string id for the given type
3232 * @param $dbkeys array of mixed
33 - * @param $diProperty mixed SMWDIProperty or null, the property for which this value is built, currently needed for records
3433 *
3534 * @return SMWDataItem
3635 */
37 - static public function dataItemFromDBKeys( $typeid, $dbkeys, $diProperty = null ) {
 36+ static public function dataItemFromDBKeys( $typeid, $dbkeys ) {
3837 switch ( SMWDataValueFactory::getDataItemId( $typeid ) ) {
3938 case SMWDataItem::TYPE_ERROR: case SMWDataItem::TYPE_NOTYPE:
4039 break;

Status & tagging log