r89157 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89156‎ | r89157 | r89158 >
Date:07:55, 30 May 2011
Author:aaron
Status:ok
Tags:
Comment:
More link function call fixes
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -1489,9 +1489,10 @@
14901490 # Make a link to the full diff-to-stable if:
14911491 # (a) Actual revs are pending and (b) We are not viewing the full diff-to-stable
14921492 if ( $article->revsArePending() && !$fullStableDiff ) {
1493 - $review = $wgUser->getSkin()->makeKnownLinkObj(
 1493+ $review = $wgUser->getSkin()->linkKnown(
14941494 $article->getTitle(),
14951495 wfMsgHtml( 'review-diff2stable' ),
 1496+ array(),
14961497 array( 'oldid' => $srev->getRevId(), 'diff' => 'cur' ) + FlaggedRevs::diffOnlyCGI()
14971498 );
14981499 $review = wfMsgHtml( 'parentheses', $review );
@@ -1561,9 +1562,11 @@
15621563 }
15631564 foreach ( $changes as $tuple ) {
15641565 list( $title, $revIdStable, $hasStable ) = $tuple;
1565 - $link = $skin->makeLinkObj( $title,
 1566+ $link = $skin->linkKnown(
 1567+ $title,
15661568 htmlspecialchars( $title->getPrefixedText() ),
1567 - 'diff=cur&oldid=' . (int)$revIdStable );
 1569+ array(),
 1570+ array( 'diff' => 'cur', 'oldid' => $revIdStable ) );
15681571 if ( !$hasStable ) {
15691572 $link = "<strong>$link</strong>";
15701573 }
@@ -1586,7 +1589,7 @@
15871590 foreach ( $changes as $tuple ) {
15881591 list( $title, $revIdStable, $hasStable ) = $tuple;
15891592 // @TODO: change when MW has file diffs
1590 - $link = $skin->makeLinkObj( $title, htmlspecialchars( $title->getPrefixedText() ) );
 1593+ $link = $skin->link( $title, htmlspecialchars( $title->getPrefixedText() ) );
15911594 if ( !$hasStable ) {
15921595 $link = "<strong>$link</strong>";
15931596 }

Status & tagging log