r89116 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r89115‎ \| r89116 \| r89117 >
Date:	15:53, 29 May 2011
Author:	reedy
Status:	deferred
Tags:
Comment:	More documentation!
Modified paths:	/trunk/phase3/languages/classes/LanguageBe_tarask.php (modified) (history) /trunk/phase3/languages/classes/LanguageBg.php (modified) (history) /trunk/phase3/languages/classes/LanguageBh.php (modified) (history) /trunk/phase3/languages/classes/LanguageBs.php (modified) (history) /trunk/phase3/languages/classes/LanguageEt.php (modified) (history) /trunk/phase3/languages/classes/LanguageHi.php (modified) (history) /trunk/phase3/languages/classes/LanguageHy.php (modified) (history) /trunk/phase3/languages/classes/LanguageKaa.php (modified) (history) /trunk/phase3/languages/classes/LanguageKk.php (modified) (history) /trunk/phase3/languages/classes/LanguageKk_cyrl.php (modified) (history) /trunk/phase3/languages/classes/LanguageKsh.php (modified) (history) /trunk/phase3/languages/classes/LanguageKu_ku.php (modified) (history) /trunk/phase3/languages/classes/LanguageLa.php (modified) (history) /trunk/phase3/languages/classes/LanguageLn.php (modified) (history) /trunk/phase3/languages/classes/LanguageMk.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/classes/LanguageLa.php
—	—	@@ -12,6 +12,11 @@
13	13	* Rules are far from complete.
14	14	*
15	15	* Cases: genitive, accusative, ablative
	16	+ *
	17	+ * @param $word string
	18	+ * @param $case string
	19	+ *
	20	+ * @return string
16	21	*/
17	22	function convertGrammar( $word, $case ) {
18	23	global $wgGrammarForms;
Index: trunk/phase3/languages/classes/LanguageHi.php
—	—	@@ -7,6 +7,11 @@
8	8	class LanguageHi extends Language {
9	9	/**
10	10	* Use singular form for zero
	11	+ *
	12	+ * @param $count int
	13	+ * @param $forms array
	14	+ *
	15	+ * @return string
11	16	*/
12	17	function convertPlural( $count, $forms ) {
13	18	if ( !count( $forms ) ) { return ''; }
Index: trunk/phase3/languages/classes/LanguageLn.php
—	—	@@ -8,7 +8,11 @@
9	9	/**
10	10	* Use singular form for zero
11	11	* http://unicode.org/repos/cldr-tmp/trunk/diff/supplemental/language_plural_rules.html#ln
12		-
	12	+ *
	13	+ * @param $count int
	14	+ * @param $forms array
	15	+ *
	16	+ * @return string
13	17	*/
14	18	function convertPlural( $count, $forms ) {
15	19	if ( !count( $forms ) ) { return ''; }
Index: trunk/phase3/languages/classes/LanguageHy.php
—	—	@@ -63,6 +63,10 @@
64	64
65	65	/**
66	66	* Armenian numeric format is "12 345,67" but "1234,56"
	67	+ *
	68	+ * @param $_ string
	69	+ *
	70	+ * @return string
67	71	*/
68	72	function commafy( $_ ) {
69	73	if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageKsh.php
—	—	@@ -64,6 +64,8 @@
65	65	*
66	66	* @param $word String
67	67	* @param $case String
	68	+ *
	69	+ * @return string
68	70	*/
69	71	function convertGrammar( $word, $case ) {
70	72	$lord = strtolower( $word );
—	—	@@ -144,6 +146,10 @@
145	147
146	148	/**
147	149	* Avoid grouping whole numbers between 0 to 9999
	150	+ *
	151	+ * @param $_ string
	152	+ *
	153	+ * @return string
148	154	*/
149	155	public function commafy( $_ ) {
150	156	if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageMk.php
—	—	@@ -8,6 +8,11 @@
9	9	/**
10	10	* Plural forms per
11	11	* http://unicode.org/repos/cldr-tmp/trunk/diff/supplemental/language_plural_rules.html#mk
	12	+ *
	13	+ * @param $count int
	14	+ * @param $forms array
	15	+ *
	16	+ * @return string
12	17	*/
13	18	function convertPlural( $count, $forms ) {
14	19	if ( !count( $forms ) ) { return ''; }
Index: trunk/phase3/languages/classes/LanguageEt.php
—	—	@@ -8,6 +8,10 @@
9	9	class LanguageEt extends Language {
10	10	/**
11	11	* Avoid grouping whole numbers between 0 to 9999
	12	+ *
	13	+ * @param $_ string
	14	+ *
	15	+ * @return string
12	16	*/
13	17	function commafy( $_ ) {
14	18	if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageBg.php
—	—	@@ -8,6 +8,10 @@
9	9	/**
10	10	* ISO number formatting: 123 456 789,99.
11	11	* Avoid tripple grouping by numbers with whole part up to 4 digits.
	12	+ *
	13	+ * @param $_ string
	14	+ *
	15	+ * @return string
12	16	*/
13	17	function commafy( $_ ) {
14	18	if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageBh.php
—	—	@@ -7,6 +7,11 @@
8	8	class LanguageBh extends Language {
9	9	/**
10	10	* Use singular form for zero
	11	+ *
	12	+ * @param $count int
	13	+ * @param $forms array
	14	+ *
	15	+ * @return string
11	16	*/
12	17	function convertPlural( $count, $forms ) {
13	18	if ( !count( $forms ) ) { return ''; }
Index: trunk/phase3/languages/classes/LanguageKaa.php
—	—	@@ -35,6 +35,10 @@
36	36
37	37	/**
38	38	* It fixes issue with lcfirst for transforming 'I' to 'ı'
	39	+ *
	40	+ * @param $string string
	41	+ *
	42	+ * @return string
39	43	*/
40	44	function lcfirst ( $string ) {
41	45	if ( substr( $string, 0, 1 ) === 'I' ) {
—	—	@@ -46,6 +50,10 @@
47	51
48	52	/**
49	53	* Avoid grouping whole numbers between 0 to 9999
	54	+ *
	55	+ * @param $_ string
	56	+ *
	57	+ * @return string
50	58	*/
51	59	function commafy( $_ ) {
52	60	if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageBs.php
—	—	@@ -34,6 +34,11 @@
35	35	# Invoked with {{GRAMMAR:case\|word}}
36	36	/**
37	37	* Cases: genitiv, dativ, akuzativ, vokativ, instrumental, lokativ
	38	+ *
	39	+ * @param $word string
	40	+ * @param $case string
	41	+ *
	42	+ * @return string
38	43	*/
39	44	function convertGrammar( $word, $case ) {
40	45	global $wgGrammarForms;
Index: trunk/phase3/languages/classes/LanguageKu_ku.php
—	—	@@ -8,6 +8,10 @@
9	9
10	10	/**
11	11	* Avoid grouping whole numbers between 0 to 9999
	12	+ *
	13	+ * @param $_ string
	14	+ *
	15	+ * @return string
12	16	*/
13	17	function commafy( $_ ) {
14	18
Index: trunk/phase3/languages/classes/LanguageBe_tarask.php
—	—	@@ -52,6 +52,10 @@
53	53	* but the characters used for this could be both U+0027 and U+2019.
54	54	* This function unifies apostrophe sign in search index values
55	55	* to enable seach using both apostrophe signs.
	56	+ *
	57	+ * @param $string string
	58	+ *
	59	+ * @return string
56	60	*/
57	61	function normalizeForSearch( $string ) {
58	62	wfProfileIn( __METHOD__ );
—	—	@@ -71,6 +75,10 @@
72	76	/**
73	77	* Four-digit number should be without group commas (spaces)
74	78	* So "1 234 567", "12 345" but "1234"
	79	+ *
	80	+ * @param $_ string
	81	+ *
	82	+ * @return string
75	83	*/
76	84	function commafy( $_ ) {
77	85	if ( preg_match( '/^-?\d{1,4}(\.\d*)?$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageKk_cyrl.php
—	—	@@ -10,6 +10,11 @@
11	11	# Invoked with {{GRAMMAR:case\|word}}
12	12	/**
13	13	* Cases: genitive, dative, accusative, locative, ablative, comitative + possessive forms
	14	+ *
	15	+ * @param $word string
	16	+ * @param $case stirng
	17	+ *
	18	+ * @return string
14	19	*/
15	20	function convertGrammarKk_cyrl( $word, $case ) {
16	21	global $wgGrammarForms;
—	—	@@ -707,6 +712,10 @@
708	713
709	714	/**
710	715	* Avoid grouping whole numbers between 0 to 9999
	716	+ *
	717	+ * @param $_ string
	718	+ *
	719	+ * @return string
711	720	*/
712	721	function commafy( $_ ) {
713	722	if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
Index: trunk/phase3/languages/classes/LanguageKk.php
—	—	@@ -347,6 +347,10 @@
348	348	return $text;
349	349	}
350	350
	351	+ /**
	352	+ * @param $key string
	353	+ * @return String
	354	+ */
351	355	function convertCategoryKey( $key ) {
352	356	return $this->autoConvert( $key, 'kk' );
353	357	}
—	—	@@ -397,6 +401,10 @@
398	402
399	403	/**
400	404	* It fixes issue with ucfirst for transforming 'i' to 'İ'
	405	+ *
	406	+ * @param $string string
	407	+ *
	408	+ * @return string
401	409	*/
402	410	function ucfirst ( $string ) {
403	411	$variant = $this->getPreferredVariant();
—	—	@@ -410,6 +418,10 @@
411	419
412	420	/**
413	421	* It fixes issue with lcfirst for transforming 'I' to 'ı'
	422	+ *
	423	+ * @param $string string
	424	+ *
	425	+ * @return string
414	426	*/
415	427	function lcfirst ( $string ) {
416	428	$variant = $this->getPreferredVariant();
—	—	@@ -421,6 +433,11 @@
422	434	return $string;
423	435	}
424	436
	437	+ /**
	438	+ * @param $word string
	439	+ * @param $case string
	440	+ * @return string
	441	+ */
425	442	function convertGrammar( $word, $case ) {
426	443	wfProfileIn( __METHOD__ );
427	444

Status & tagging log

11:26, 5 June 2011 Hashar (talk | contribs) changed the status of r89116 [removed: new added: deferred]