r89089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89088‎ | r89089 | r89090 >
Date:11:05, 29 May 2011
Author:hartman
Status:deferred
Tags:
Comment:
What is the point in using <img> width: height: with 100% ? Might as well set the actual values if we have them already, saves one step in the rendering of the page.
Modified paths:
  • /trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php
——@@ -97,7 +97,8 @@
9898 'data-videopayload' => $this->getXmlMediaTagOutput( $this->getPopupPlayerSize() ),
9999 ),
100100 Xml::tags( 'img', array(
101 - 'style' => 'width:100%;height:100%;',
 101+ 'style' => "width:" . intval( $this->width ) . "px;height:" .
 102+ intval( $this->height ) . "px",
102103 'src' => $this->getUrl(),
103104 ),'')
104105 .

Status & tagging log