r89086 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89085‎ | r89086 | r89087 >
Date:04:19, 29 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
Only whitelist it if QUnit is in that mode though (bug in QUnit?), caused it to report an error if not in noglobals mode. (Follow-up r89085)
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.js
@@ -65,7 +65,9 @@
6666 ok( window.anotherGlobalMapChecker, 'new mw.Map( true ) did store its values in the global window object' );
6767
6868 // Whitelist this global variable for QUnit 'noglobal' mode
69 - QUnit.config.pollution.push( 'anotherGlobalMapChecker' );
 69+ if ( QUnit.config.noglobals ) {
 70+ QUnit.config.pollution.push( 'anotherGlobalMapChecker' );
 71+ }
7072 });
7173
7274 test( 'mw.config', function(){

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89085Fix issues raised through TestSwarm...krinkle04:11, 29 May 2011

Status & tagging log