r89080 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89079‎ | r89080 | r89081 >
Date:01:30, 29 May 2011
Author:nelson
Status:ok
Tags:
Comment:
the documentation and variable names for FileRepo->append() are correct, but they got positionally swapped at implementation time
Modified paths:
  • /trunk/extensions/ResumableUpload/ResumableUploadHandler.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ResumableUpload/ResumableUploadHandler.php
@@ -146,7 +146,7 @@
147147
148148 if ( $this->getRealPath( $this->repoPath ) ) {
149149 if ( $this->getSize( $this->repoPath ) == $this->mChunkOffset ) {
150 - $this->status = $this->appendToUploadFile( $this->repoPath, $this->mTempPath );
 150+ $this->status = $this->appendToUploadFile( $this->mTempPath, $this->repoPath );
151151 if ( $this->mFileSize > $wgMaxUploadSize )
152152 $this->status = Status::newFatal( 'largefileserver' );
153153 } else {
@@ -165,6 +165,7 @@
166166 */
167167 public function finalizeFile() {
168168 $this->appendChunk();
 169+ $this->appendFinal( $this->repoPath );
169170 $this->mTempPath = $this->getRealPath( $this->repoPath );
170171 }
171172 }

Status & tagging log