r89077 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89076‎ | r89077 | r89078 >
Date:01:15, 29 May 2011
Author:wikinaut
Status:deferred
Tags:
Comment:
essage=changed the misleading error message when already logged in: it is of course not an error, when the user is already logged in; show already logged in instead. guide the users to their OpenID tab in the preferences (is the tab number fixed, I don't think so)
Modified paths:
  • /trunk/extensions/OpenID/OpenID.i18n.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.i18n.php
@@ -49,7 +49,11 @@
5050 'openidfailure' => 'Verification failed',
5151 'openidfailuretext' => 'Verification of the OpenID URL failed. Error message: "$1"',
5252 'openidsuccess' => 'Verification succeeded',
53 - 'openidsuccesstext' => 'Verification of the OpenID URL succeeded.',
 53+ 'openidsuccesstext' => "'''Successful verification and log in as user $1'''.
 54+
 55+Your OpenID is $2 .
 56+
 57+This and further OpenIDs, and an optional account password, can be managed in your [[Special:Preferences|preferences]].",
5458 'openidusernameprefix' => 'OpenIDUser',
5559 'openidserverlogininstructions' => '$3 requests that you enter your password for your user $2 page $1 (this is your OpenID URL)',
5660 'openidtrustinstructions' => 'Check if you want to share data with $1.',
@@ -80,9 +84,10 @@
8185 'openidconvertsuccesstext' => 'You have successfully converted your OpenID to $1.',
8286 'openidconvertyourstext' => 'That is already your OpenID.',
8387 'openidconvertothertext' => 'That is someone else\'s OpenID.',
84 - 'openidalreadyloggedin' => "'''You are already logged in, $1!'''
 88+ 'openidalreadyloggedin' => 'You are already logged in.',
 89+ 'openidalreadyloggedintext' => "'''You are already logged in, $1!'''
8590
86 -If you want to use OpenID to log in in the future, you can [[Special:OpenIDConvert|convert your account to use OpenID]].",
 91+You can manage (view, delete, add further) OpenIDs in the OpenID tab of your [[Special:Preferences#preftab-8|preferences]].",
8792 'openidnousername' => 'No username specified.',
8893 'openidbadusername' => 'Bad username specified.',
8994 'openidautosubmit' => 'This page includes a form that should be automatically submitted if you have JavaScript enabled.
Index: trunk/extensions/OpenID/SpecialOpenIDLogin.body.php
@@ -79,15 +79,15 @@
8080 }
8181
8282 /**
83 - * Displays an error message saying that the user is already logged-in
 83+ * Displays an info message saying that the user is already logged-in
8484 */
8585 function alreadyLoggedIn() {
8686 global $wgUser, $wgOut;
8787
88 - $wgOut->setPageTitle( wfMsg( 'openiderror' ) );
 88+ $wgOut->setPageTitle( wfMsg( 'openidalreadyloggedin' ) );
8989 $wgOut->setRobotPolicy( 'noindex,nofollow' );
9090 $wgOut->setArticleRelated( false );
91 - $wgOut->addWikiMsg( 'openidalreadyloggedin', $wgUser->getName() );
 91+ $wgOut->addWikiMsg( 'openidalreadyloggedintext', $wgUser->getName() );
9292 list( $returnto, $returntoquery ) = $this->returnTo();
9393 $wgOut->returnToMain( false, $returnto, $returntoquery );
9494 }
@@ -596,7 +596,7 @@
597597 $wgOut->setPageTitle( wfMsg( 'openidsuccess' ) );
598598 $wgOut->setRobotPolicy( 'noindex,nofollow' );
599599 $wgOut->setArticleRelated( false );
600 - $wgOut->addWikiMsg( 'openidsuccess', $wgUser->getName(), $openid );
 600+ $wgOut->addWikiMsg( 'openidsuccesstext', $wgUser->getName(), $openid );
601601 $wgOut->addHtml( $inject_html );
602602 list( $returnto, $returntoquery ) = $this->returnTo();
603603 $wgOut->returnToMain( false, $returnto, $returntoquery );

Status & tagging log