r89054 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89053‎ | r89054 | r89055 >
Date:18:33, 28 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
add credits for lib authors
Modified paths:
  • /trunk/extensions/Spark/Spark.class.php (modified) (history)
  • /trunk/extensions/Spark/Spark.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Spark/Spark.i18n.php
@@ -18,7 +18,7 @@
1919 * @author Jeroen De Dauw
2020 */
2121 $messages['en'] = array(
22 - 'spark-desc' => 'Adds a <code><nowiki><spark /></nowiki></code> tag that enables embedding [http://km.aifb.kit.edu/sites/spark/ Spark] mash-ups.',
 22+ 'spark-desc' => 'Adds a <code><nowiki><spark /></nowiki></code> tag that enables embedding [http://km.aifb.kit.edu/sites/spark/ Spark] mash-ups. The spark library was created by Denny Vrandecic and Andreas Harth.',
2323 'spark-missing-query' => 'You need to specify a query using the "data-spark-query" parameter.',
2424 );
2525
Index: trunk/extensions/Spark/Spark.class.php
@@ -49,9 +49,9 @@
5050 $query = str_replace( array( '&lt;', '&gt;' ), array( '<', '>' ), $query );
5151 unset( $this->parameters['data-spark-query'] );
5252
53 - return '<nowiki><div class="spark" data-spark-query="' . $query . '" ' . Html::expandAttributes( $this->parameters ) . ' >' .
 53+ return '<div class="spark" data-spark-query="' . $query . '" ' . Html::expandAttributes( $this->parameters ) . ' >' .
5454 ( is_null( $this->contents ) ? '' : htmlspecialchars( $this->contents ) ) .
55 - '</div></nowiki>';
 55+ '</div>';
5656 }
5757 else {
5858 return Html::element( 'i', array(), wfMsg( 'spark-missing-query' ) );

Status & tagging log