r89031 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89030‎ | r89031 | r89032 >
Date:10:52, 28 May 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Fixed bug where gallery elements were removed so that after a few refreshes of a gallery there were no images left
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
——@@ -460,7 +460,7 @@
461461 }
462462
463463 var titles = '';
464 - var imageList = currentTypeOrSubtype.gallery.imageList;
 464+ var imageList = currentTypeOrSubtype.gallery.imageList.slice( 0 );
465465 for( var i=0; i<currentTypeOrSubtype.gallery.number; i++ ) {
466466 // get a randomimage
467467 var id = Math.floor( Math.random() * imageList.length );

Status & tagging log