r88969 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88968‎ | r88969 | r88970 >
Date:12:32, 27 May 2011
Author:reedy
Status:ok
Tags:
Comment:
MFB r88946
Modified paths:
  • /branches/REL1_18/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/installer/Installer.php
@@ -1446,9 +1446,10 @@
14471447 $params['language'] = $myLang;
14481448 }
14491449
1450 - $res = Http::post( $this->mediaWikiAnnounceUrl, array( 'postData' => $params ) );
1451 - if( !$res ) {
1452 - $s->warning( 'config-install-subscribe-fail' );
 1450+ $res = MWHttpRequest::factory( $this->mediaWikiAnnounceUrl,
 1451+ array( 'method' => 'POST', 'postData' => $params ) )->execute();
 1452+ if( !$res->isOK() ) {
 1453+ $s->warning( 'config-install-subscribe-fail', $res->getMessage() );
14531454 }
14541455 }
14551456

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88946Fix Bug #28829 - “Failure to subscribe to mediawiki-announce is not reporte...mah23:12, 26 May 2011

Status & tagging log