r88967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88966‎ | r88967 | r88968 >
Date:11:43, 27 May 2011
Author:reedy
Status:ok
Tags:
Comment:
MFB r88946
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -1455,10 +1455,11 @@
14561456 $params['language'] = $myLang;
14571457 }
14581458
1459 - $res = Http::post( $this->mediaWikiAnnounceUrl, array( 'postData' => $params ) );
1460 - if( !$res ) {
1461 - $s->warning( 'config-install-subscribe-fail' );
1462 - }
 1459+ $res = MWHttpRequest::factory( $this->mediaWikiAnnounceUrl,
 1460+ array( 'method' => 'POST', 'postData' => $params ) )->execute();
 1461+ if( !$res->isOK() ) {
 1462+ $s->warning( 'config-install-subscribe-fail', $res->getMessage() );
 1463+ }
14631464 }
14641465
14651466 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88946Fix Bug #28829 - “Failure to subscribe to mediawiki-announce is not reporte...mah23:12, 26 May 2011

Status & tagging log