r88966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88965‎ | r88966 | r88967 >
Date:11:20, 27 May 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Removed error for not entering a message and added rationale
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -278,9 +278,16 @@
279279 if( $( '#mw-wikilove-header' ).val().length <= 0 ) {
280280 $.wikiLove.showError( 'wikilove-err-header' ); return false;
281281 }
 282+
 283+ /*
 284+ Let's not show an error for not entering a message, making it always optional.
 285+ This is preferred over removing the field from the interface, so that users are
 286+ stimulated to enter a message, but are not required to do so if they want to leave
 287+ a quick gesture of appreciation.
282288 if( $( '#mw-wikilove-message' ).val().length <= 0 ) {
283289 $.wikiLove.showError( 'wikilove-err-msg' ); return false;
284290 }
 291+ */
285292
286293 // If there isn't a signature already in the message, throw an error
287294 if ( $( '#mw-wikilove-message' ).val().indexOf( '~~~' ) >= 0 ) {

Status & tagging log