r88964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88963‎ | r88964 | r88965 >
Date:10:41, 27 May 2011
Author:ialex
Status:ok
Tags:
Comment:
Fix for r85600: added isset() checks, otherwise it throws notices when not using CLDR
Modified paths:
  • /trunk/extensions/SiteMatrix/SiteMatrix_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SiteMatrix/SiteMatrix_body.php
@@ -337,7 +337,7 @@
338338 }
339339
340340 $langDisplay = $langNames[$lang];
341 - if ( strlen( $localLanguageNames[$lang] ) && $langDisplay != $localLanguageNames[$lang] ) {
 341+ if ( isset( $localLanguageNames[$lang] ) && strlen( $localLanguageNames[$lang] ) && $langDisplay != $localLanguageNames[$lang] ) {
342342 $langDisplay .= ' (' . $localLanguageNames[$lang] . ')';
343343 }
344344 $s .= '<td>' . $anchor . Xml::element( 'strong', $attribs, $langDisplay ) . '</td>';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85600* (bug 22984) add local language name to Special:SiteMatrix...reedy00:32, 7 April 2011

Status & tagging log