r88943 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88942‎ | r88943 | r88944 >
Date:22:50, 26 May 2011
Author:brion
Status:ok
Tags:
Comment:
Remove stray require_once of GlobalFunctions.php from EditUser extension's setup file (added in r43509 to support an incorrectly placed wfDebug() call which has long since been removed)

Apparently violating MediaWiki's operating assumptions here was in some circumstances causing breakage due to wfDebug() being updated to include hooks calls: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88843#c17219
Modified paths:
  • /trunk/extensions/EditUser/EditUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EditUser/EditUser.php
——@@ -10,9 +10,6 @@
1111
1212 $dir = dirname(__FILE__) . '/';
1313
14 -#in case we're running a maintenance script and GlobalFunctions.php isn't loaded...
15 -require_once("$IP/includes/GlobalFunctions.php");
16 -
1714 $wgExtensionCredits['specialpage'][] = array(
1815 'path' => __FILE__,
1916 'name' => 'EditUser',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43509* final fixes for this extension (updated current branch for updated Prefs, a...skizzerz23:05, 14 November 2008

Status & tagging log