r88916 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88915‎ | r88916 | r88917 >
Date:19:07, 26 May 2011
Author:diederik
Status:deferred
Tags:
Comment:
Renamed variables to increase consistency
Modified paths:
  • /trunk/tools/editor_trends/etl/downloader.py (modified) (history)

Diff [purge]

Index: trunk/tools/editor_trends/etl/downloader.py
@@ -54,19 +54,19 @@
5555 properties.dump_relative_path,
5656 filename)
5757 mod_date = text_utils.convert_timestamp_to_datetime_naive(mod_date, properties.timestamp_server)
58 - if file_utils.check_file_exists(properties.location, filename):
59 - mod_loc = file_utils.get_modified_date(properties.location, filename)
 58+ if file_utils.check_file_exists(properties.input_location, filename):
 59+ mod_loc = file_utils.get_modified_date(properties.input_location, filename)
6060 if mod_loc == mod_date and (properties.force == False or properties.force == None):
6161 print 'You already have downloaded the most recent %s%s dumpfile.' % (properties.language.code, properties.project.name)
6262 continue
6363
6464 if filemode == 'w':
65 - fh = file_utils.create_txt_filehandle(properties.location,
 65+ fh = file_utils.create_txt_filehandle(properties.input_location,
6666 filename,
6767 filemode,
6868 properties.encoding)
6969 else:
70 - fh = file_utils.create_binary_filehandle(properties.location, filename, 'wb')
 70+ fh = file_utils.create_binary_filehandle(properties.input_location, filename, 'wb')
7171
7272 if filesize != -1:
7373 pbar = progressbar.ProgressBar(widgets=widgets, maxval=filesize).start()