r88908 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88907‎ | r88908 | r88909 >
Date:17:54, 26 May 2011
Author:dale
Status:deferred
Tags:
Comment:
added some configuration documentation
fixed getMetadataType method to include $image param
fixed fadeOut of $targetTip for fullscreen f11 tip
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/resources/mw.PopUpThumbVideo.js (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler.hooks.php
@@ -101,7 +101,7 @@
102102 if( $article->getTitle()->getNamespace() == NS_FILE ) {
103103
104104 $file = wfFindFile( $article->getTitle() );
105 - $mediaType = $file->getHandler()->getMetadataType();
 105+ $mediaType = $file->getHandler()->getMetadataType( $image = '' );
106106
107107 if( $mediaType == 'webm' || $mediaType == 'ogg' ){
108108 WebVideoTranscode::removeTranscodeJobs( $file );
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php
@@ -54,6 +54,7 @@
5555 // if the browser should display a warning for direct file links:
5656 "EmbedPlayer.DirectFileLinkWarning" => false,
5757
 58+ // A link to download firefox
5859 "EmbedPlayer.FirefoxLink" => 'http://www.mozilla.com/en-US/firefox/upgrade.html?from=mwEmbed',
5960
6061 // If fullscreen is global enabled.
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/skins/mw.PlayerControlBuilder.js
@@ -487,6 +487,7 @@
488488 if( $.browser.safari && /chrome/.test(navigator.userAgent.toLowerCase()) ){
489489 return ;
490490 }
 491+ //
491492
492493 // OSX has a different short cut than windows and liux
493494 var toolTipMsg = ( navigator.userAgent.toLowerCase().indexOf('Mac OS X') != -1 )?
@@ -503,7 +504,7 @@
504505
505506 var hideTip = function(){
506507 mw.setConfig('EmbedPlayer.FullscreenTip', false );
507 - $targetWarning.fadeOut('fast');
 508+ $targetTip.fadeOut('fast');
508509 };
509510
510511 // Hide fullscreen tip if:
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js
@@ -223,7 +223,7 @@
224224 }
225225
226226 // Allow extensions to detect and add their own "players"
227 - mw.log("trigger::embedPlayerUpdateMediaPlayersEvent");
 227+ mw.log("EmbedPlayer::trigger:embedPlayerUpdateMediaPlayersEvent");
228228 $( mw ).trigger( 'embedPlayerUpdateMediaPlayersEvent' , this.mediaPlayers );
229229
230230 },
Index: trunk/extensions/TimedMediaHandler/resources/mw.PopUpThumbVideo.js
@@ -16,13 +16,14 @@
1717 'close' : function(){
1818 // pause the video on close ( so that playback does not continue )
1919 var domEl = $(this).find('video,audio').get(0);
20 - if( domEl ) {
 20+ if( domEl && domEl.pause ) {
2121 domEl.pause();
2222 }
 23+ return true;
2324 }
2425 } )
2526 .css('overflow', 'hidden')
26 - .find('video,audio').embedPlayer();
 27+ .find('video,audio').embedPlayer();
2728 // don't follow file link
2829 return false;
2930 });

Status & tagging log