r88833 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88832‎ | r88833 | r88834 >
Date:20:41, 25 May 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r88832, rem debug code
Modified paths:
  • /trunk/extensions/SemanticWatchlist/api/ApiQuerySemanticWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/api/ApiQuerySemanticWatchlist.php
@@ -52,12 +52,7 @@
5353 $this->mergeSets( $resultSets );
5454 }
5555
56 - //$this->getResult()->setIndexedTagName( $resultSets, 'set' );
57 -
5856 foreach ( $resultSets as &$set ) {
59 - if ( !is_object( $set )) {
60 - var_dump($set);exit;
61 - }
6257 $set = $set->toArray();
6358
6459 foreach ( $set['changes'] as $propName => $changes ) {
@@ -65,6 +60,8 @@
6661 }
6762 }
6863
 64+ $this->getResult()->setIndexedTagName( $resultSets, 'set' );
 65+
6966 $this->getResult()->addValue(
7067 null,
7168 'sets',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88832implemented set merging to not show duplicate changes on the watchlistjeroendedauw20:39, 25 May 2011

Status & tagging log