r88825 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88824‎ | r88825 | r88826 >
Date:19:52, 25 May 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r88215
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/CentralAuth/SpecialWikiSets.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/CentralAuth/SpecialWikiSets.php
@@ -42,6 +42,7 @@
4343 $this->buildMainView();
4444 }
4545 } else {
 46+ $newPage = ( $subpage === '0' && $this->mCanEdit );
4647 if ( $subpage ) {
4748 $set = is_numeric( $subpage ) ? WikiSet::newFromId( $subpage ) : WikiSet::newFromName( $subpage );
4849 if ( $set ) {
@@ -54,9 +55,9 @@
5556 }
5657 }
5758
58 - if ( ( $subpage || $subpage === '0' ) && $this->mCanEdit && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
 59+ if ( ( $subpage || $newPage ) && $this->mCanEdit && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
5960 $this->doSubmit( $subpage );
60 - } else if ( ( $subpage || $subpage === '0' ) && is_numeric( $subpage ) ) {
 61+ } else if ( ( $subpage || $newPage ) && is_numeric( $subpage ) ) {
6162 $this->buildSetView( $subpage );
6263 } else {
6364 $this->buildMainView();
@@ -97,12 +98,6 @@
9899 $wgOut->setSubtitle( wfMsgExt( 'centralauth-editset-subtitle', 'parseinline' ) );
99100
100101 $set = ( $subpage || $subpage === '0' ) ? WikiSet::newFromID( $subpage ) : null;
101 - if( !$set ) {
102 - $wgOut->setPageTitle( wfMsg( 'error' ) );
103 - $error = wfMsgExt( 'centralauth-editset-notfound', array( 'escapenoentities' ), $subpage );
104 - $this->buildMainView( "<strong class='error'>{$error}</strong>" );
105 - return;
106 - }
107102
108103 if ( !$name ) $name = $set ? $set->getName() : '';
109104 if ( !$type ) $type = $set ? $set->getType() : WikiSet::OPTIN;
Property changes on: branches/wmf/1.17wmf1/extensions/CentralAuth/SpecialWikiSets.php
___________________________________________________________________
Added: svn:mergeinfo
110105 Merged /branches/REL1_15/phase3/extensions/CentralAuth/SpecialWikiSets.php:r51646
111106 Merged /branches/wmf/1.16wmf4/extensions/CentralAuth/SpecialWikiSets.php:r67177,69199,76243,77266
112107 Merged /branches/sqlite/extensions/CentralAuth/SpecialWikiSets.php:r58211-58321
113108 Merged /trunk/extensions/CentralAuth/specials/SpecialWikiSets.php:r88215
114109 Merged /trunk/phase3/extensions/CentralAuth/SpecialWikiSets.php:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,80406,81833,83212,83590
115110 Merged /branches/new-installer/phase3/extensions/CentralAuth/SpecialWikiSets.php:r43664-66004
116111 Merged /branches/wmf-deployment/extensions/CentralAuth/SpecialWikiSets.php:r60970

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88215Properly fix bug 28678, by not allowing to enter the set creation page in...vasilievvv05:24, 16 May 2011

Status & tagging log