r88799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88798‎ | r88799 | r88800 >
Date:16:14, 25 May 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix undefined variable from r39635
Modified paths:
  • /trunk/phase3/includes/parser/Parser_LinkHooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser_LinkHooks.php
@@ -227,7 +227,7 @@
228228 wfProfileOut( __METHOD__."-misc" );
229229 # Make title object
230230 wfProfileIn( __METHOD__."-title" );
231 - $title = Title::newFromText( $this->mStripState->unstripNoWiki($titleText) );
 231+ $title = Title::newFromText( $this->mStripState->unstripNoWiki( $titleText ) );
232232 if( !$title ) {
233233 wfProfileOut( __METHOD__."-title" );
234234 wfProfileOut( __METHOD__ );
@@ -239,7 +239,7 @@
240240 # Default for Namespaces is a default link
241241 # ToDo: Default for patterns is plain wikitext
242242 $return = true;
243 - if( isset($this->mLinkHooks[$ns]) ) {
 243+ if( isset( $this->mLinkHooks[$ns] ) ) {
244244 list( $callback, $flags ) = $this->mLinkHooks[$ns];
245245 if( $flags & SLH_PATTERN ) {
246246 $args = array( $parser, $holders, $markers, $titleText, &$paramText, &$leadingColon );
@@ -248,7 +248,7 @@
249249 }
250250 # Workaround for PHP bug 35229 and similar
251251 if ( !is_callable( $callback ) ) {
252 - throw new MWException( "Tag hook for $name is not callable\n" );
 252+ throw new MWException( "Tag hook for namespace $ns is not callable\n" );
253253 }
254254 $return = call_user_func_array( $callback, $args );
255255 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39635Committing todays work on LinkHooks and the link rewrite:...dantman04:44, 19 August 2008

Status & tagging log