r88786 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88785‎ | r88786 | r88787 >
Date:12:10, 25 May 2011
Author:janpaul123
Status:ok
Tags:
Comment:
Modified paths:
  • /trunk/extensions/WikiLove/WikiLove.hooks.php (modified) (history)
  • /trunk/extensions/WikiLove/WikiLove.php (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css (modified) (history)
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.icon.css (added) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/WikiLove.php
@@ -70,11 +70,18 @@
7171 // api modules
7272 $wgAPIModules['wikilove'] = 'WikiLoveApi';
7373
 74+$extWikiLoveTpl = array(
 75+ 'localBasePath' => dirname( __FILE__ ) . '/modules/ext.wikiLove',
 76+ 'remoteExtPath' => 'WikiLove/modules/ext.wikiLove',
 77+);
 78+
7479 // resources
7580 $wgResourceModules += array(
76 - 'ext.wikiLove' => array(
77 - 'localBasePath' => dirname( __FILE__ ) . '/modules/ext.wikiLove',
78 - 'remoteExtPath' => 'WikiLove/modules/ext.wikiLove',
 81+ 'ext.wikiLove.icon' => $extWikiLoveTpl + array(
 82+ 'styles' => 'ext.wikiLove.icon.css',
 83+ 'position' => 'top',
 84+ ),
 85+ 'ext.wikiLove' => $extWikiLoveTpl + array(
7986 'scripts' => array(
8087 'ext.wikiLove.core.js',
8188 'ext.wikiLove.defaultOptions.js',
Index: trunk/extensions/WikiLove/WikiLove.hooks.php
@@ -54,6 +54,7 @@
5555
5656 $title = self::getUserTalkPage( $skin->getTitle() );
5757 if ( !is_null( $title ) ) {
 58+ $out->addModules( 'ext.wikiLove.icon' );
5859 $out->addModules( 'ext.wikiLove' );
5960 }
6061 return true;
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.css
@@ -1,46 +1,3 @@
2 -/* include fix from r87101 here for older versions; these three blocks can become deprecated later */
3 -div.vectorTabs span {
4 - display: inline-block;
5 - /* @embed */
6 - background-image: url(images/tab-break.png);
7 - background-position: bottom right;
8 - background-repeat: no-repeat;
9 -}
10 -
11 -div.vectorTabs li a {
12 - background-image: none;
13 -}
14 -
15 -#ca-unwatch.icon,
16 -#ca-watch.icon {
17 - margin-right: 0px;
18 -}
19 -
20 -/* icon style */
21 -#ca-wikilove.icon a {
22 - margin: 0;
23 - padding: 0;
24 - outline: none;
25 - display: block;
26 - width: 27px;
27 - /* This hides the text but shows the background image */
28 - padding-top: 3.1em;
29 - margin-top: 0;
30 - /* Only applied in IE6 */
31 - margin-top: -0.8em !ie;
32 - height: 0;
33 - overflow: hidden;
34 - /* @embed */
35 - background-image: url(images/heart-icons.png);
36 -}
37 -#ca-wikilove.icon a {
38 - background-position: 5px 60%;
39 -}
40 -#ca-wikilove.icon a:hover,
41 -#ca-wikilove.icon a:focus {
42 - background-position: -19px 60%;
43 -}
44 -
452 /* dialog */
463 #mw-wikilove-dialog {
474 margin: 10px;
Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.icon.css
@@ -0,0 +1,42 @@
 2+/* include fix from r87101 here for older versions; these three blocks can become deprecated later */
 3+div.vectorTabs span {
 4+ display: inline-block;
 5+ /* @embed */
 6+ background-image: url(images/tab-break.png);
 7+ background-position: bottom right;
 8+ background-repeat: no-repeat;
 9+}
 10+
 11+div.vectorTabs li a {
 12+ background-image: none;
 13+}
 14+
 15+#ca-unwatch.icon,
 16+#ca-watch.icon {
 17+ margin-right: 0px;
 18+}
 19+
 20+/* icon style */
 21+#ca-wikilove.icon a {
 22+ margin: 0;
 23+ padding: 0;
 24+ outline: none;
 25+ display: block;
 26+ width: 27px;
 27+ /* This hides the text but shows the background image */
 28+ padding-top: 3.1em;
 29+ margin-top: 0;
 30+ /* Only applied in IE6 */
 31+ margin-top: -0.8em !ie;
 32+ height: 0;
 33+ overflow: hidden;
 34+ /* @embed */
 35+ background-image: url(images/heart-icons.png);
 36+}
 37+#ca-wikilove.icon a {
 38+ background-position: 5px 60%;
 39+}
 40+#ca-wikilove.icon a:hover,
 41+#ca-wikilove.icon a:focus {
 42+ background-position: -19px 60%;
 43+}
Property changes on: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.icon.css
___________________________________________________________________
Added: svn:eol-style
144 + native

Status & tagging log