r88737 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88736‎ | r88737 | r88738 >
Date:18:56, 24 May 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r87565: FormEdit does not rely on initialized wgParser anymore
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -29,6 +29,8 @@
3030 function execute( $query, $redirectOnError = true ) {
3131 global $wgRequest, $wgOut;
3232
 33+ wfProfileIn( __METHOD__ );
 34+
3335 $this->setHeaders();
3436 $this->mForm = $wgRequest->getVal( 'form' );
3537 $this->mTarget = $wgRequest->getVal( 'target' );
@@ -64,6 +66,9 @@
6567 } else {
6668 $this->mError = null;
6769 }
 70+
 71+ wfProfileOut( __METHOD__ );
 72+
6873 }
6974
7075 static function printAltFormsList( $alt_forms, $target_name ) {
@@ -209,7 +214,7 @@
210215 // underlines - hopefully this won't
211216 // cause problems of its own
212217 $target_name = str_replace( ' ', '_', $target_name );
213 - $target_name = $wgParser->recursiveTagParse( $target_name );
 218+ $target_name = $wgParser->transformMsg( $target_name, ParserOptions::newFromUser( null ) );
214219
215220 $title_number = "";
216221 $isRandom = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87565revert switch from recursiveTagParse to parsefoxtrott19:55, 6 May 2011