r88702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88701‎ | r88702 | r88703 >
Date:22:58, 23 May 2011
Author:brion
Status:ok
Tags:
Comment:
Follow-up to r88678: fix regression breaking all CheckUser IP lookups (mistyped field names, implies the code was never tested)
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -423,7 +423,7 @@
424424
425425 $ret = $dbr->select(
426426 'cu_changes',
427 - array( 'cu_ip', 'cu_ip_hex', 'MIN(cuc_timestamp) AS first', 'MAX(cuc_timestamp) AS last' ),
 427+ array( 'cuc_ip', 'cuc_ip_hex', 'MIN(cuc_timestamp) AS first', 'MAX(cuc_timestamp) AS last' ),
428428 array( 'cuc_user' => $user_id, $time_conds ),
429429 __METHOD__,
430430 array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88678Remove old freeResult()...reedy20:21, 23 May 2011

Status & tagging log