r88664 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88663‎ | r88664 | r88665 >
Date:18:52, 23 May 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r84475: Block::parseTarget() should always return an array.
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -1007,9 +1007,9 @@
10081008 # We may have been through this before
10091009 if( $target instanceof User ){
10101010 if( IP::isValid( $target->getName() ) ){
1011 - return self::TYPE_IP;
 1011+ return array( $target, self::TYPE_IP );
10121012 } else {
1013 - return self::TYPE_USER;
 1013+ return array( $target, self::TYPE_USER );
10141014 }
10151015 } elseif( $target === null ){
10161016 return array( null, null );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84475Blame hashar for this giant commit; he teased me for making so many smaller o...happy-melon19:12, 21 March 2011

Status & tagging log