r88651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88650‎ | r88651 | r88652 >
Date:17:05, 23 May 2011
Author:bawolff
Status:ok
Tags:
Comment:
Make the onParserTestTables method static, since the hook is called statically.

Fixes: Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method MathHooks::onParserTestTables() should not be called statically in /var/www/w/phase3/includes/Hooks.php on line 235
Modified paths:
  • /trunk/extensions/Math/Math.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Math/Math.hooks.php
——@@ -133,7 +133,7 @@
134134 * @param array $tables
135135 * @return bool
136136 */
137 - function onParserTestTables( &$tables ) {
 137+ static function onParserTestTables( &$tables ) {
138138 $tables[] = 'math';
139139 return true;
140140 }

Status & tagging log