r88648 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88647‎ | r88648 | r88649 >
Date:16:37, 23 May 2011
Author:ialex
Status:reverted (Comments)
Tags:
Comment:
exit -> return now that we are in a function
Modified paths:
  • /trunk/phase3/index.php (modified) (history)

Diff [purge]

Index: trunk/phase3/index.php
@@ -88,7 +88,7 @@
8989 } else {
9090 echo "Waiting for a database server: $lag seconds lagged\n";
9191 }
92 - exit;
 92+ return;
9393 }
9494 }
9595
@@ -108,7 +108,7 @@
109109 $dispatcher->performAction();
110110 wfProfileOut( 'index.php' );
111111 $mediaWiki->restInPeace();
112 - exit;
 112+ return;
113113 }
114114
115115 if ( $wgUseFileCache && $wgTitle !== null ) {
@@ -132,7 +132,7 @@
133133 $mediaWiki->finalCleanup();
134134 wfProfileOut( 'index.php' );
135135 $mediaWiki->restInPeace();
136 - exit;
 136+ return;
137137 }
138138 }
139139 wfProfileOut( 'index.php-filecache' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r89361Revert r88648 per CRdemon20:15, 2 June 2011

Comments

#Comment by Platonides (talk | contribs)   15:42, 2 June 2011

I don't like it. It works, but only because index.php does nothing below calling wfIndexMain(). Conceptually the exit() were much clear.

#Comment by 😂 (talk | contribs)   15:45, 2 June 2011

+1.

#Comment by Hashar (talk | contribs)   20:10, 2 June 2011

So what do we do? Revert it back to exit?

#Comment by 😂 (talk | contribs)   20:15, 2 June 2011

Yes.

Status & tagging log