r88638 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88637‎ | r88638 | r88639 >
Date:13:47, 23 May 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r88633:
*Check useOnlyIfProtected()
*Fixed URL param name typo added before commit
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedRevsUI.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedRevsUI.hooks.php
@@ -330,7 +330,10 @@
331331 }
332332
333333 public static function addHideReviewedFilter( $specialPage, &$filters ) {
334 - $filters['hideReviewed'] = array( 'msg' => 'flaggedrevs-hidereviewed', 'default' => false );
 334+ if ( !FlaggedRevs::useOnlyIfProtected() ) {
 335+ $filters['hideReviewed'] = array(
 336+ 'msg' => 'flaggedrevs-hidereviewed', 'default' => false );
 337+ }
335338 return true;
336339 }
337340
@@ -419,7 +422,7 @@
420423 $fields[] = 'fp_stable';
421424 $fields[] = 'fp_pending_since';
422425 $join_conds['flaggedpages'] = array( 'LEFT JOIN', 'fp_page_id = rc_cur_id' );
423 - if ( $wgRequest->getBool( 'hidereviewed' ) ) {
 426+ if ( $wgRequest->getBool( 'hideReviewed' ) && !FlaggedRevs::useOnlyIfProtected() ) {
424427 $conds[] = 'rc_timestamp >= fp_pending_since OR fp_stable IS NULL';
425428 }
426429 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88633* In core:...aaron04:28, 23 May 2011

Status & tagging log