r88626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88625‎ | r88626 | r88627 >
Date:23:55, 22 May 2011
Author:wikinaut
Status:deferred
Tags:
Comment:
moved path addition from LocalSettings to OpenID.setup.php to make installation easier
Modified paths:
  • /trunk/extensions/OpenID/OpenID.setup.php (modified) (history)
  • /trunk/extensions/OpenID/TODO (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.setup.php
@@ -27,8 +27,11 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.924-beta' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.925-beta' );
3232
 33+$path = dirname( __FILE__ );
 34+set_include_path( implode( PATH_SEPARATOR, array( $path ) ) . PATH_SEPARATOR . get_include_path() );
 35+
3336 # CONFIGURATION VARIABLES
3437
3538 /**
@@ -240,7 +243,7 @@
241244 return $rel;
242245 }
243246
244 -$dir = dirname( __FILE__ ) . '/';
 247+$dir = $path . '/';
245248
246249 $wgExtensionMessagesFiles['OpenID'] = $dir . 'OpenID.i18n.php';
247250 $wgExtensionAliasesFiles['OpenID'] = $dir . 'OpenID.alias.php';
@@ -293,7 +296,7 @@
294297 $wgGroupPermissions['sysop']['openid-dashboard-admin'] = true;
295298
296299 $myResourceTemplate = array(
297 - 'localBasePath' => dirname( __FILE__ ) . '/skin',
 300+ 'localBasePath' => $path . '/skin',
298301 'remoteExtPath' => 'OpenID/skin',
299302 'group' => 'ext.openid',
300303 );
Index: trunk/extensions/OpenID/TODO
@@ -1,4 +1,4 @@
2 -Status: 0.924-beta 20110521
 2+Status: 0.925-beta 20110523
33
44 ? more details are needed to understand the "to do"
55 * resolved, or partially resolved, wontfix
@@ -12,7 +12,11 @@
1313 ? Provider-driven identifier selection (eh? do we care?)
1414 ? Auto-login if you've logged in before with an OpenID,
1515 and are logged into that account now
16 -
 16+
 17+- redesign MediaWiki extension and php-openid library paths to avoid
 18+ $path=array( dirname( __FILE__ ) );
 19+ set_include_path(implode(PATH_SEPARATOR,$path).PATH_SEPARATOR.get_include_path());
 20+ in OpenID.setup.php. I don't know, if it can be avoided.
1721 - allow user to set a password in case of !$wgOpenIDClientOnly && $wgOpenIDOnly
1822 (https://bugzilla.wikimedia.org/show_bug.cgi?id=29027)
1923 = case Server/OpenID-Only

Status & tagging log