r88619 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88618‎ | r88619 | r88620 >
Date:23:20, 22 May 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 29101) Special:FileDuplicateSearch shows silly message

Patch by William Demchick
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -76,6 +76,7 @@
7777 changes to talk page in addition to watchlist edits.
7878 * (bug 29071) mediawiki.action.watch.ajax.js should pass uselang to API.
7979 * (bug 28272) Special:Allmessages should have only one "Go" button
 80+* (bug 29101) Special:FileDuplicateSearch shows silly message
8081
8182 === API changes in 1.19 ===
8283 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php
@@ -118,7 +118,7 @@
119119
120120 if( $this->file ) {
121121 $this->hash = $this->file->getSha1();
122 - } else {
 122+ } elseif( $this->filename !== '' ) {
123123 $wgOut->wrapWikiMsg(
124124 "<p class='mw-fileduplicatesearch-noresults'>\n$1\n</p>",
125125 array( 'fileduplicatesearch-noresults', wfEscapeWikiText( $this->filename ) )

Status & tagging log