r88608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88607‎ | r88608 | r88609 >
Date:22:05, 22 May 2011
Author:platonides
Status:ok
Tags:
Comment:
Changes to doc-comments. /* to /** in language folder.
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageBe_tarask.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageHy.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageIu.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageKaa.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageKk.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageKu.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageRu.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageSr.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageUk.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -2478,7 +2478,7 @@
24792479 return $string;
24802480 }
24812481
2482 - /*
 2482+ /**
24832483 * Truncate a string of valid HTML to a specified length in bytes,
24842484 * appending an optional string (e.g. for ellipses), and return valid HTML
24852485 *
@@ -2610,7 +2610,7 @@
26112611 return $skipCount;
26122612 }
26132613
2614 - /*
 2614+ /**
26152615 * truncateHtml() helper function
26162616 * (a) push or pop $tag from $openTags as needed
26172617 * (b) clear $tag value
Index: trunk/phase3/languages/classes/LanguageHy.php
@@ -55,10 +55,9 @@
5656 return ( abs( $count ) <= 1 ) ? $forms[0] : $forms[1];
5757 }
5858
59 - /*
 59+ /**
6060 * Armenian numeric format is "12 345,67" but "1234,56"
6161 */
62 -
6362 function commafy( $_ ) {
6463 if ( !preg_match( '/^\d{1,4}$/', $_ ) ) {
6564 return strrev( (string)preg_replace( '/(\d{3})(?=\d)(?!\d*\.)/', '$1,', strrev( $_ ) ) );
Index: trunk/phase3/languages/classes/LanguageIu.php
@@ -105,7 +105,7 @@
106106 return parent::parserConvert( $text, $parser );
107107 }
108108
109 - /*
 109+ /**
110110 * A function wrapper:
111111 * - if there is no selected variant, leave the link
112112 * names as they were
@@ -125,7 +125,7 @@
126126 $link = $oldlink;
127127 }
128128
129 - /*
 129+ /**
130130 * We want our external link captions to be converted in variants,
131131 * so we return the original text instead -{$text}-, except for URLs
132132 */
@@ -135,7 +135,7 @@
136136 return $text;
137137 }
138138
139 - /*
 139+ /**
140140 * An ugly function wrapper for parsing Image titles
141141 * (to prevent image name conversion)
142142 */
Index: trunk/phase3/languages/classes/LanguageUk.php
@@ -79,7 +79,7 @@
8080 }
8181 }
8282
83 - /*
 83+ /**
8484 * Ukrainian numeric format is "12 345,67" but "1234,56"
8585 */
8686 function commafy( $_ ) {
Index: trunk/phase3/languages/classes/LanguageKaa.php
@@ -19,9 +19,9 @@
2020 /* Full code of function convertGrammar() is in development. Updates coming soon. */
2121 return $word;
2222 }
23 - /*
 23+
 24+ /**
2425 * It fixes issue with ucfirst for transforming 'i' to 'İ'
25 - *
2626 */
2727 function ucfirst ( $string ) {
2828 if ( substr( $string, 0, 1 ) === 'i' ) {
@@ -31,9 +31,8 @@
3232 }
3333 }
3434
35 - /*
 35+ /**
3636 * It fixes issue with lcfirst for transforming 'I' to 'ı'
37 - *
3837 */
3938 function lcfirst ( $string ) {
4039 if ( substr( $string, 0, 1 ) === 'I' ) {
Index: trunk/phase3/languages/classes/LanguageRu.php
@@ -93,7 +93,7 @@
9494 }
9595 }
9696
97 - /*
 97+ /**
9898 * Four-digit number should be without group commas (spaces)
9999 * See manual of style at http://ru.wikipedia.org/wiki/Википедия:Оформление_статей
100100 * So "1 234 567", "12 345" but "1234"
Index: trunk/phase3/languages/classes/LanguageBe_tarask.php
@@ -11,12 +11,12 @@
1212
1313 class LanguageBe_tarask extends Language {
1414 /**
15 - * Plural form transformations
16 - *
17 - * $wordform1 - singular form (for 1, 21, 31, 41...)
18 - * $wordform2 - plural form (for 2, 3, 4, 22, 23, 24, 32, 33, 34...)
19 - * $wordform3 - plural form (for 0, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 25, 26...)
20 - */
 15+ * Plural form transformations
 16+ *
 17+ * $wordform1 - singular form (for 1, 21, 31, 41...)
 18+ * $wordform2 - plural form (for 2, 3, 4, 22, 23, 24, 32, 33, 34...)
 19+ * $wordform3 - plural form (for 0, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 25, 26...)
 20+ */
2121
2222 function convertPlural( $count, $forms ) {
2323 if ( !count( $forms ) ) { return ''; }
@@ -41,7 +41,7 @@
4242 }
4343 }
4444
45 - /*
 45+ /**
4646 * The Belarusian language uses apostrophe sign,
4747 * but the characters used for this could be both U+0027 and U+2019.
4848 * This function unifies apostrophe sign in search index values
@@ -62,7 +62,7 @@
6363 return $s;
6464 }
6565
66 - /*
 66+ /**
6767 * Four-digit number should be without group commas (spaces)
6868 * So "1 234 567", "12 345" but "1234"
6969 */
Index: trunk/phase3/languages/classes/LanguageKk.php
@@ -211,7 +211,7 @@
212212 return $carray;
213213 }
214214
215 - /*
 215+ /**
216216 * A function wrapper:
217217 * - if there is no selected variant, leave the link
218218 * names as they were
@@ -231,7 +231,7 @@
232232 $link = $oldlink;
233233 }
234234
235 - /*
 235+ /**
236236 * An ugly function wrapper for parsing Image titles
237237 * (to prevent image name conversion)
238238 */
@@ -337,7 +337,7 @@
338338 }
339339 }
340340
341 - /*
 341+ /**
342342 * We want our external link captions to be converted in variants,
343343 * so we return the original text instead -{$text}-, except for URLs
344344 */
@@ -395,9 +395,8 @@
396396 }
397397 }
398398
399 - /*
 399+ /**
400400 * It fixes issue with ucfirst for transforming 'i' to 'İ'
401 - *
402401 */
403402 function ucfirst ( $string ) {
404403 $variant = $this->getPreferredVariant();
@@ -409,9 +408,8 @@
410409 return $string;
411410 }
412411
413 - /*
 412+ /**
414413 * It fixes issue with lcfirst for transforming 'I' to 'ı'
415 - *
416414 */
417415 function lcfirst ( $string ) {
418416 $variant = $this->getPreferredVariant();
Index: trunk/phase3/languages/classes/LanguageKu.php
@@ -132,7 +132,7 @@
133133 );
134134 }
135135
136 - /*
 136+ /**
137137 * A function wrapper:
138138 * - if there is no selected variant, leave the link
139139 * names as they were
@@ -152,7 +152,7 @@
153153 $link = $oldlink;
154154 }
155155
156 - /*
 156+ /**
157157 * We want our external link captions to be converted in variants,
158158 * so we return the original text instead -{$text}-, except for URLs
159159 */
@@ -162,7 +162,7 @@
163163 return $text;
164164 }
165165
166 - /*
 166+ /**
167167 * An ugly function wrapper for parsing Image titles
168168 * (to prevent image name conversion)
169169 */
Index: trunk/phase3/languages/classes/LanguageSr.php
@@ -77,7 +77,7 @@
7878 return $carray;
7979 }
8080
81 - /*
 81+ /**
8282 * A function wrapper:
8383 * - if there is no selected variant, leave the link
8484 * names as they were
@@ -97,7 +97,7 @@
9898 $link = $oldlink;
9999 }
100100
101 - /*
 101+ /**
102102 * We want our external link captions to be converted in variants,
103103 * so we return the original text instead -{$text}-, except for URLs
104104 */
@@ -107,7 +107,7 @@
108108 return $text;
109109 }
110110
111 - /*
 111+ /**
112112 * An ugly function wrapper for parsing Image titles
113113 * (to prevent image name conversion)
114114 */

Status & tagging log