r88603 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r88602
|
r88603
|
r88604
>
Date:
20:17, 22 May 2011
Author:
hartman
Status:
deferred
Tags:
Comment:
Remove unnecessary height calculation for thumbnail in credits, based on Aspect ratio of the video/audio player elements.
Now the thumbnail for audio elements is properly presented instead of being squashed down to 2 pixels height.
Modified paths:
/trunk/extensions/MwEmbedSupport/MwEmbedModules/MediaWikiSupport/resources/mw.MediaWikiPlayerSupport.js
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/MwEmbedSupport/MwEmbedModules/MediaWikiSupport/resources/mw.MediaWikiPlayerSupport.js
—
—
@@ -184,8 +184,7 @@
185
185
'border': 0,
186
186
'src' : embedPlayer.poster
187
187
} ).css( {
188
- 'width' : imgWidth,
189
- 'height': parseInt( imgWidth * ( embedPlayer.height / embedPlayer.width ) )
188
+ 'width' : imgWidth
190
189
} )
191
190
)
192
191
)
Status & tagging log
21:14, 22 May 2011
Reedy
(
talk
|
contribs
)
changed the
status
of r88603
[
removed:
new
added:
deferred]