| Index: trunk/extensions/CodeReview/CodeReview.i18n.php |
| — | — | @@ -122,6 +122,7 @@ |
| 123 | 123 | 'code-pathsearch-filter' => 'Filter applied:', |
| 124 | 124 | 'code-revfilter-cr_status' => 'Status = $1', |
| 125 | 125 | 'code-revfilter-cr_author' => 'Author = $1', |
| | 126 | + 'code-revfilter-ct_tag' => 'Tag = $1', |
| 126 | 127 | 'code-revfilter-clear' => 'Clear filter', |
| 127 | 128 | 'code-rev-submit' => 'Save changes', |
| 128 | 129 | 'code-rev-submit-accesskey' => 's', |
| Index: trunk/extensions/CodeReview/ui/WordCloud.php |
| — | — | @@ -86,7 +86,7 @@ |
| 87 | 87 | */ |
| 88 | 88 | public function getCloudHtml() { |
| 89 | 89 | if( 0 === count( $this->wordsArray ) ) { |
| 90 | | - return; |
| | 90 | + return ''; |
| 91 | 91 | } |
| 92 | 92 | $this->shuffleCloud(); |
| 93 | 93 | $max = max( $this->wordsArray ); |
| — | — | @@ -98,10 +98,16 @@ |
| 99 | 99 | } |
| 100 | 100 | return '<div class="mw-wordcloud">' . $return . '</div>'; |
| 101 | 101 | } |
| | 102 | + return ''; |
| 102 | 103 | } |
| 103 | 104 | |
| 104 | 105 | /** |
| 105 | 106 | * Default text callback for word display |
| | 107 | + * |
| | 108 | + * @param $word string |
| | 109 | + * @param $sizeRange |
| | 110 | + * |
| | 111 | + * @return string |
| 106 | 112 | */ |
| 107 | 113 | public function defaultTextCallback( $word, $sizeRange ) { |
| 108 | 114 | return Html::element( 'span', array( |
| — | — | @@ -128,6 +134,8 @@ |
| 129 | 135 | /** |
| 130 | 136 | * Get the class range using a percentage |
| 131 | 137 | * |
| | 138 | + * @param $percent |
| | 139 | + * |
| 132 | 140 | * @return Int |
| 133 | 141 | */ |
| 134 | 142 | private function getClassFromPercent( $percent ) { |
| Index: trunk/extensions/CodeReview/ui/CodeView.php |
| — | — | @@ -112,7 +112,7 @@ |
| 113 | 113 | protected $mView; |
| 114 | 114 | |
| 115 | 115 | /** |
| 116 | | - * @param $view CodeView |
| | 116 | + * @param $view CodeView |
| 117 | 117 | * |
| 118 | 118 | */ |
| 119 | 119 | function __construct( $view ) { |
| Index: trunk/extensions/CodeReview/ui/CodeCommentsListView.php |
| — | — | @@ -1,6 +1,6 @@ |
| 2 | 2 | <?php |
| 3 | 3 | |
| 4 | | -// Special:Code/MediaWiki |
| | 4 | +// Special:Code/MediaWiki/comments |
| 5 | 5 | class CodeCommentsListView extends CodeView { |
| 6 | 6 | public $mRepo; |
| 7 | 7 | |
| — | — | @@ -33,7 +33,7 @@ |
| 34 | 34 | } |
| 35 | 35 | } |
| 36 | 36 | |
| 37 | | -// Pager for CodeRevisionListView |
| | 37 | +// Pager for CodeCommentsListView |
| 38 | 38 | class CodeCommentsTablePager extends SvnTablePager { |
| 39 | 39 | |
| 40 | 40 | function isFieldSortable( $field ) { |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php |
| — | — | @@ -9,6 +9,11 @@ |
| 10 | 10 | public $mPath, $batchForm; |
| 11 | 11 | |
| 12 | 12 | /** |
| | 13 | + * @var |
| | 14 | + */ |
| | 15 | + protected $filters = array(); |
| | 16 | + |
| | 17 | + /** |
| 13 | 18 | * @param $repo CodeRepository|String |
| 14 | 19 | */ |
| 15 | 20 | function __construct( $repo ) { |
| — | — | @@ -26,17 +31,16 @@ |
| 27 | 32 | $this->mAuthor = $wgRequest->getText( 'author' ); |
| 28 | 33 | $this->mStatus = $wgRequest->getText( 'status' ); |
| 29 | 34 | |
| 30 | | - $filters = array(); |
| 31 | 35 | if ( $this->mAuthor ) { |
| 32 | | - $filters[] = wfMsg( 'code-revfilter-cr_author', $this->mAuthor ); |
| | 36 | + $this->filters[] = wfMsg( 'code-revfilter-cr_author', $this->mAuthor ); |
| 33 | 37 | } |
| 34 | 38 | if ( $this->mStatus ) { |
| 35 | | - $filters[] = wfMsg( 'code-revfilter-cr_status', $this->mStatus ); |
| | 39 | + $this->filters[] = wfMsg( 'code-revfilter-cr_status', $this->mStatus ); |
| 36 | 40 | } |
| 37 | 41 | |
| 38 | | - if ( count( $filters) ) { |
| | 42 | + if ( count( $this->filters ) ) { |
| 39 | 43 | global $wgLang; |
| 40 | | - $this->mAppliedFilter = $wgLang->listToText( $filters ); |
| | 44 | + $this->mAppliedFilter = $wgLang->listToText( $this->filters ); |
| 41 | 45 | } else { |
| 42 | 46 | $this->mAppliedFilter = null; |
| 43 | 47 | } |
| — | — | @@ -362,7 +366,7 @@ |
| 363 | 367 | SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/' . $value ), |
| 364 | 368 | htmlspecialchars( $value ), |
| 365 | 369 | array(), |
| 366 | | - $pathQuery |
| | 370 | + array() |
| 367 | 371 | ); |
| 368 | 372 | case 'cr_status': |
| 369 | 373 | $options = $pathQuery; |
| Index: trunk/extensions/CodeReview/ui/CodeRevisionTagView.php |
| — | — | @@ -2,8 +2,12 @@ |
| 3 | 3 | |
| 4 | 4 | class CodeRevisionTagView extends CodeRevisionListView { |
| 5 | 5 | function __construct( $repo, $tag ) { |
| | 6 | + $this->mTag = $tag; |
| | 7 | + |
| | 8 | + if ( $this->mTag ) { |
| | 9 | + $this->filters[] = wfMsg( 'code-revfilter-ct_tag', $this->mTag ); |
| | 10 | + } |
| 6 | 11 | parent::__construct( $repo ); |
| 7 | | - $this->mTag = $tag; |
| 8 | 12 | } |
| 9 | 13 | |
| 10 | 14 | function getPager() { |