r88572 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88571‎ | r88572 | r88573 >
Date:12:46, 22 May 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
do not include namespace prefix in the wikitext of property data values
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Property.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_WikiPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_Property.php
@@ -210,7 +210,7 @@
211211 }
212212
213213 public function getWikiValue() {
214 - return $this->isVisible() ? ( ( $this->isInverse() ? '-' : '' ) . $this->getWikiPageValue()->getWikiValue() ) : '';
 214+ return $this->isVisible() ? ( ( $this->isInverse() ? '-' : '' ) . $this->m_dataitem->getLabel() ) : '';
215215 }
216216
217217 /**
Index: trunk/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_WikiPage.php
@@ -313,8 +313,8 @@
314314 * If a fixed namespace is set, we do not return the namespace prefix explicitly.
315315 */
316316 protected function getCaption() {
317 - return $this->m_caption !== false ? $this->m_caption:
318 - ( $this->m_fixNamespace == NS_MAIN ? $this->getPrefixedText():$this->getText() );
 317+ return $this->m_caption !== false ? $this->m_caption :
 318+ ( $this->m_fixNamespace == NS_MAIN ? $this->getPrefixedText() : $this->getText() );
319319 }
320320
321321 /**

Status & tagging log