r88566 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88565‎ | r88566 | r88567 >
Date:10:27, 22 May 2011
Author:mkroetzsch
Status:deferred
Tags:
Comment:
moved some default implementations to the base class
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_QueryPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialProperties.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_SpecialProperties.php
@@ -47,19 +47,6 @@
4848 */
4949 class SMWPropertiesPage extends SMWQueryPage {
5050
51 - function getName() {
52 - // TODO: should probably use SMW prefix
53 - return "Properties";
54 - }
55 -
56 - function isExpensive() {
57 - return false; // Disables caching for now
58 - }
59 -
60 - function isSyndicated() {
61 - return false; // TODO: why not?
62 - }
63 -
6451 function getPageHeader() {
6552 return '<p>' . wfMsg( 'smw_properties_docu' ) . "</p><br />\n";
6653 }
Index: trunk/extensions/SemanticMediaWiki/specials/QueryPages/SMW_QueryPage.php
@@ -29,6 +29,18 @@
3030 /// TODO
3131 }
3232
 33+ function getName() {
 34+ return "SMWQueryPage";
 35+ }
 36+
 37+ function isExpensive() {
 38+ return false; // Disables caching for now
 39+ }
 40+
 41+ function isSyndicated() {
 42+ return false; // TODO: why not?
 43+ }
 44+
3345 /**
3446 * This is the actual workhorse. It does everything needed to make a
3547 * real, honest-to-gosh query page.
@@ -104,8 +116,7 @@
105117 public function getSkin() {
106118 if ( method_exists( 'SpecialPage', 'getSkin' ) ) {
107119 return parent::getSkin();
108 - }
109 - else {
 120+ } else {
110121 global $wgUser;
111122 return $wgUser->getSkin();
112123 }

Status & tagging log