r88548 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88547‎ | r88548 | r88549 >
Date:21:05, 21 May 2011
Author:krinkle
Status:ok
Tags:
Comment:
Changing float to text-align for conveniencelinks and editreasons links. Since headings have overflow:hidden this is causing the border to stop when this block is touched (atleast in Chrome/Safari), since headings don't clear float. This doesn't have to be a float from what I can see and is better done as text-align so that any later elements on the page will not be affected by the page flow.
Remove the line from Vector's main.css since it was already in shared.css
Modified paths:
  • /trunk/phase3/skins/common/shared.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/rtl.css
——@@ -216,7 +216,7 @@
217217 /* Convenience links to edit block, delete and protect reasons */
218218 p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
219219 p.mw-filedelete-editreasons, p.mw-delete-editreasons {
220 - float: left;
 220+ text-align: left;
221221 }
222222
223223 .toggle {
Index: trunk/phase3/skins/common/shared.css
——@@ -164,7 +164,7 @@
165165 p.mw-filedelete-editreasons, p.mw-delete-editreasons,
166166 p.mw-revdel-editreasons {
167167 font-size: 90%;
168 - float: right;
 168+ text-align: right;
169169 }
170170
171171 /*
Index: trunk/phase3/skins/vector/screen.css
——@@ -1216,12 +1216,6 @@
12171217 background-repeat:no-repeat;
12181218 }
12191219
1220 -/* Convenience links to edit block, delete and protect reasons */
1221 -p.mw-ipb-conveniencelinks, p.mw-protect-editreasons,
1222 -p.mw-filedelete-editreasons, p.mw-delete-editreasons {
1223 - float: right;
1224 -}
1225 -
12261220 /* Tooltips are outside of the normal body code, so this helps make the size of the text sensible */
12271221 .tipsy {
12281222 font-size: 0.8em;

Status & tagging log